linux-ext4 - Re: [RFC PATCH 4/9][e2fsprogs] Add 64-bit alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080512144353.GC7029@mit.edu>
Date:	Mon, 12 May 2008 10:43:53 -0400
From:	Theodore Tso <tytso@....edu>
To:	"Jose R. Santos" <jrs@...ibm.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [RFC PATCH 4/9][e2fsprogs] Add 64-bit alloc_stats interface.

On Fri, May 09, 2008 at 11:39:52AM -0500, Jose R. Santos wrote:
> +	/*FIXME: Not blk64_t clean */

Suggestion, please use "FIXME-64" instead of fixme so it's easier to
clean this up later.

>  	int	group = ext2fs_group_of_blk(fs, blk);

Might as well fix this in the initial patch series, earlier --- and
let's *not* make it be an inline function.  Yeah, we call
ext2fs_group_of_blk and ext2fs_group_of_ino a fair amount, but #1, on
32-bit machines, the 64 bit arithmemtic makes the function bigger, and
#2, modern CPU's have greatly reduced the cost of procedure
activations.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html