linux-ext4 - Re: barriers off by default?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <482CDC27.4090505@redhat.com>
Date:	Thu, 15 May 2008 19:58:15 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Jan Kara <jack@...e.cz>
CC:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: barriers off by default?

Jan Kara wrote:
> On Thu 15-05-08 15:44:04, Eric Sandeen wrote:


>> +	if (!test_opt(sb, BARRIER)) {
>> +		seq_puts(seq, ",barrier=0");
>> +	} else {
>> +		/*
>> +	 	* jbd inherits the barrier flag from ext3, and jbd may actually
>> +	 	* turn off barriers if a write fails, so it's the real test.
>> +	 	*/
>> +		if (journal && !(journal->j_flags & JFS_BARRIER))
>> +			seq_puts(seq, ",barrier=1(failed)");
>> +	}

Actually, since /proc/mounts should substitute for mtab I should not be
putting chatty informational messages in there, should I!

        /*
         * jbd inherits the barrier flag from ext3, and jbd may actually
         * turn off barriers if a write fails, so it's the real test.
         */
        if (!test_opt(sb, BARRIER) ||
            (journal && !(journal->j_flags & JFS_BARRIER)))
                seq_puts(seq, ",barrier=0");

is a better plan.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html