linux-ext4 - remove bashism in lib/blkid/test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 25 May 2008 18:00:06 +0200 (CEST)
From:	Christian Kujau <lists@...dbynature.de>
To:	linux-ext4@...r.kernel.org
Subject: remove bashism in lib/blkid/test_probe.in

Hi,

while running "make check" on a current e2fsprogs.pu git tree fails with:

----
cramfs: + test ! -f ./tests/cramfs.img.bz2 -a ! -f ./tests/cramfs.results
+ bunzip2
+ [ cramfs == swap0 ]
[: 1: ==: unexpected operator
+ [ cramfs == swap1 ]
[: 1: ==: unexpected operator
----

My /bin/sh is not linked to bash but to dash (which is basically "sh") and 
thus "==" comparisons fail. checkbashisms (part of Debian's devscripts)
catches this too:

----
possible bashism in ./test_probe line 26 (should be 'b = a'):
         if [ "$i" == "swap0" ]; then
----

Changing == to = makes "make check" happy :)
http://nerdbynature.de/bits/e2fsprogs.pu/test_probe.in.diff.txt

Thanks,
Christian.
-- 
BOFH excuse #169:

broadcast packets on wrong frequency
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html