linux-ext4 - Re: bh_count undeclared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080525233809.GG5970@mit.edu>
Date:	Sun, 25 May 2008 19:38:09 -0400
From:	Theodore Tso <tytso@....EDU>
To:	Christian Kujau <lists@...dbynature.de>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: bh_count undeclared

On Sun, May 25, 2008 at 05:35:12PM +0200, Christian Kujau wrote:
> Hi,
>
> while trying to build the current e2fsprogs.pu git tree, I got:
>
> journal.c: In function ‘getblk’:
> journal.c:76: error: ‘bh_count’ undeclared (first use in this function)
>
> When looking at journal.c I see 'bh_count' declared within an #ifdef, but 
> even when compiling with --enable-jfs-debug the error persists. Right now I 
> just removed the #ifdef so that the build succeeds.
>
> But, what's the real issue here?

Whoops, my bad.  I was compiling with --enable-jfs-debug, and I didn't
notice the change I made broke things without that configuration
option.

The right fix is just to surround the bh_count reference with an
#ifdef CONFIG_JBD_DEBUG.

It's part of a quickie mechanism for detecting buffer head leaks,
which (for example) was how I detected a problem in ext4's journal
checksum recovery code.  I had made some changes to how it worked
while I was tracking down the problem, and accidentally introduced
that compile time bug.  My bad, I'll fix it.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html