linux-ext4 - Re: [PATCH e2fsprogs] Add ZFS detection to libblkid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080602074102.GA3242@nb.net.home>
Date:	Mon, 2 Jun 2008 09:41:02 +0200
From:	Karel Zak <kzak@...hat.com>
To:	"Ricardo M. Correia" <Ricardo.M.Correia@....COM>
Cc:	"Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
	Andreas Dilger <adilger@....COM>
Subject: Re: [PATCH e2fsprogs] Add ZFS detection to libblkid

On Fri, May 30, 2008 at 07:20:47PM +0100, Ricardo M. Correia wrote:
> This patch adds ZFS filesystem detection to libblkid.

 It'd be nice to add ZFS detection to libvolume_id from udev package.

> Unfortunately the probe table doesn't support probing from the end of
> the device, otherwise we could also probe in the 3rd and 4th labels (in
> case the first 2 labels were accidentally overwritten)..

 This shouldn't be a problem in libvolume_id.

> +static int probe_zfs(struct blkid_probe *probe, struct blkid_magic *id,
> +		     unsigned char *buf)
> +{
> +	char *vdev_label;
> +	const char *pool_name = 0;
> +
> +	/* read nvpair data for pool name, pool GUID (complex) */
> +	//blkid_set_tag(probe->dev, "LABEL", pool_name, sizeof(pool_name));
> +	//set_uuid(probe->dev, pool_guid, 0);

 C++ ?

> -		if (memcmp(id->bim_magic, buf + (id->bim_sboff&0x3ff),
> +		if (memcmp(id->bim_magic, buf + (id->bim_sboff & 0x3ff),

 ???

    Karel

-- 
 Karel Zak  <kzak@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html