linux-ext4 - Re: [RFC][PATCH 3/6] delalloc ENOSPC: reserve blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080602083229.GB29995@skywalker>
Date:	Mon, 2 Jun 2008 14:02:29 +0530
From:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	Mingming Cao <cmm@...ibm.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: [RFC][PATCH 3/6] delalloc ENOSPC: reserve blocks

On Sun, Jun 01, 2008 at 04:35:55PM -0700, Mingming Cao wrote:
> ext4: delalloc ENOSPC handling core
> 
> From: Mingming cao <cmm@...ibm.com>
> 
> Core part of delaloc ENOSPC (block reservation.) 
> data/meta blocks are reserved on write_begin(), and per-inode reserved counters
> are updated  after block allocation.

I am not clear about ext4_da_release_space. Are we accounting for the
blocks related to meta-data blocks allocated ? . In
ext4_da_get_block_write we get the number of data blocks allocated.
and we don't update sbi->s_freeblocks_counter in the block allocator
any more. So request for meta-data blocks are not updating the
sbi->s_freeblocks_counter. In ext4_da_release_space we  update
the  sbi->s_freeblocks_counter without considering the above. Am  I
missing something ?

-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html