lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080602093459.GC30613@duck.suse.cz> Date: Mon, 2 Jun 2008 11:35:00 +0200 From: Jan Kara <jack@...e.cz> To: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com> Cc: cmm@...ibm.com, linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext4: Fix delalloc sync hang with journal lock inversion > @@ -1052,6 +1051,7 @@ static int __mpage_da_writepage(struct page *page, > head = page_buffers(page); > bh = head; > do { > + I guess this line is a typo. > BUG_ON(buffer_locked(bh)); > if (buffer_dirty(bh)) > mpage_add_bh_to_extent(mpd, logical, bh); > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 789b6ad..655b8bf 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -881,7 +881,12 @@ int write_cache_pages(struct address_space *mapping, > pagevec_init(&pvec, 0); > if (wbc->range_cyclic) { > index = mapping->writeback_index; /* Start from prev offset */ > - end = -1; > + /* > + * write only till the specified range_end even in cyclic mode > + */ > + end = wbc->range_end >> PAGE_CACHE_SHIFT; > + if (!end) > + end = -1; > } else { > index = wbc->range_start >> PAGE_CACHE_SHIFT; > end = wbc->range_end >> PAGE_CACHE_SHIFT; Are you sure you won't break other users of range_cyclic with this change? Honza -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists