linux-ext4 - Re: [PATCH]ext4: Fix ext4_mb_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <484349D5.2020104@cn.fujitsu.com>
Date:	Mon, 02 Jun 2008 09:16:05 +0800
From:	Shen Feng <shen@...fujitsu.com>
To:	cmm@...ibm.com
CC:	Theodore Tso <tytso@....edu>, akpm@...ux-foundation.org,
	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Akira Fujita <a-fujita@...jp.nec.com>
Subject: Re: [PATCH]ext4: Fix ext4_mb_init_cache return error



Mingming Cao Wrote:
> ext4: Fix ext4_mb_init_cache return error
> 
> From: Mingming Cao <cmm@...ibm.com>
> 
> ext4_mb_init_cache() incorrectly always return EIO on success. This
> causes the caller of ext4_mb_init_cache() fail when it checks
>  the return value.
> 
> Signed-off-by: Mingming Cao <cmm@...ibm.com>
> ---
>  fs/ext4/mballoc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.26-rc4/fs/ext4/mballoc.c
> ===================================================================
> --- linux-2.6.26-rc4.orig/fs/ext4/mballoc.c	2008-06-01 12:55:19.000000000 -0700
> +++ linux-2.6.26-rc4/fs/ext4/mballoc.c	2008-06-01 12:55:23.000000000 -0700
> @@ -798,7 +798,7 @@ static int ext4_mb_init_cache(struct pag
>  	for (i = 0; i < groups_per_page && bh[i]; i++)
>  		wait_on_buffer(bh[i]);
>  
> -	err = -EIO;
> +	err = 0;
>  	for (i = 0; i < groups_per_page && bh[i]; i++)
>  		if (!buffer_uptodate(bh[i]))
>  			goto out;
> 
> 

I think the fix should be

   	err = -EIO;
  	for (i = 0; i < groups_per_page && bh[i]; i++)
  		if (!buffer_uptodate(bh[i]))
  			goto out;
 +	err = 0;

Is that right?

Shen Feng
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html