lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080602124944.GM30613@duck.suse.cz> Date: Mon, 2 Jun 2008 14:49:44 +0200 From: Jan Kara <jack@...e.cz> To: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> Cc: akpm@...ux-foundation.org, sct@...hat.com, adilger@...sterfs.com, linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org, jack@...e.cz, jbacik@...hat.com, cmm@...ibm.com, tytso@....edu, sugita <yumiko.sugita.yf@...achi.com>, Satoshi OSHIMA <satoshi.oshima.fk@...achi.com> Subject: Re: [PATCH 5/5] ext3: abort ext3 if the journal has aborted On Mon 02-06-08 19:48:41, Hidehiro Kawai wrote: > Subject: [PATCH 5/5] ext3: abort ext3 if the journal has aborted > > If the journal has aborted due to a checkpointing failure, we > have to keep the contents of the journal space. ext3_put_super() > detects the journal abort, then it invokes ext3_abort() to make > the filesystem read only and keep needs_recovery flag. > > Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> ... > @@ -2373,7 +2374,13 @@ static void ext3_write_super_lockfs(stru > > /* Now we set up the journal barrier. */ > journal_lock_updates(journal); > - journal_flush(journal); > + > + /* > + * We don't want to clear needs_recovery flag when we failed > + * to flush the journal. > + */ > + if (journal_flush(journal) < 0) > + return; > > /* Journal blocked and flushed, clear needs_recovery flag. */ > EXT3_CLEAR_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER); It's a bit scary that LVM will start creating filesystem snapshot when journal_flush() failed but since there's no way to propagate error further up, I guess we cannot do anything better. You can add: Acked-by: Jan Kara <jack@...e.cz> Honza -- Jan Kara <jack@...e.cz> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists