linux-ext4 - Re: [PATCH e2fsprogs] Add ZFS detection to libblkid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20080602231102.GR2961@webber.adilger.int>
Date:	Mon, 02 Jun 2008 17:11:02 -0600
From:	Andreas Dilger <adilger@....com>
To:	Karel Zak <kzak@...hat.com>
Cc:	"Ricardo M. Correia" <Ricardo.M.Correia@....com>,
	"Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH e2fsprogs] Add ZFS detection to libblkid

On Jun 03, 2008  00:31 +0200, Karel Zak wrote:
> On Mon, Jun 02, 2008 at 03:38:48PM -0600, Andreas Dilger wrote:
> > On Jun 02, 2008  22:58 +0200, Karel Zak wrote:
> > > On Mon, Jun 02, 2008 at 04:01:03PM +0100, Ricardo M. Correia wrote:
> > > > Hi Karel,
> > > > 
> > > > On Seg, 2008-06-02 at 09:41 +0200, Karel Zak wrote:
> > > > 
> > > > >  It'd be nice to add ZFS detection to libvolume_id from udev package.
> > > > 
> > > > 
> > > > Interesting, I didn't know libvolume_id existed.
> > > > Is there a reason why there should be 2 different libraries doing what
> > > > appears to be essentially the same thing?
> > > 
> > >  I'm just merging these two libraries to libfsprobe :-)
> > >  http://git.kernel.org/?p=utils/util-linux-ng/util-linux-ng.git;a=shortlog;h=topic/fsprobe
> > 
> > Hrm, having "fs" in the name is a bit unfortunate, since several of the
> > things that libblkid detects are not filesystems (e.g. MD, swap).
> > Similarly, libvolume_id also does not contain "fs" in the name...
> 
>  Any suggestion? (Frankly, I don't care about names...)

To be honest, I'd prefer if you just kept the existing name(s) and merged
the functionality of the two libraries into one.  That avoids the need to
re-code either set of applications, and also avoids the risk of a yet
_another_ library in addition to libblkid and libvolume_id that is used
in a few places each.

Failing that, how about "libdevprobe"?

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html