lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20080603153506.8a9ca2a4.akpm@linux-foundation.org> Date: Tue, 3 Jun 2008 15:35:06 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> Cc: sct@...hat.com, adilger@...sterfs.com, linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org, jack@...e.cz, jbacik@...hat.com, cmm@...ibm.com, tytso@....edu, yumiko.sugita.yf@...achi.com, satoshi.oshima.fk@...achi.com Subject: Re: [PATCH 3/5] jbd: abort when failed to log metadata buffers On Mon, 02 Jun 2008 19:46:02 +0900 Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> wrote: > Subject: [PATCH 3/5] jbd: abort when failed to log metadata buffers > > If we failed to write metadata buffers to the journal space and > succeeded to write the commit record, stale data can be written > back to the filesystem as metadata in the recovery phase. > > To avoid this, when we failed to write out metadata buffers, > abort the journal before writing the commit record. > > Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> > --- > fs/jbd/commit.c | 3 +++ > 1 file changed, 3 insertions(+) > > Index: linux-2.6.26-rc4/fs/jbd/commit.c > =================================================================== > --- linux-2.6.26-rc4.orig/fs/jbd/commit.c > +++ linux-2.6.26-rc4/fs/jbd/commit.c > @@ -734,6 +734,9 @@ wait_for_iobuf: > /* AKPM: bforget here */ > } > > + if (err) > + journal_abort(journal, err); > + > jbd_debug(3, "JBD: commit phase 6\n"); > > if (journal_write_commit_record(journal, commit_transaction)) > I assume this has all been tested? How are you finding these problems and testing the fixes? Fault injection? Does it make sense to proceed into phase 6 here, or should we bale out of commit at this point? -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists