| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <20080605053043.GO2961@webber.adilger.int> Date: Wed, 04 Jun 2008 23:30:43 -0600 From: Andreas Dilger <adilger@....com> To: akpm@...ux-foundation.org Cc: mm-commits@...r.kernel.org, duaneg@...da.com, linux-ext4@...r.kernel.org Subject: Re: + ext2-dont-inherit-inappropriate-inode-flags-from-parent.patch added to -mm tree On Jun 04, 2008 21:37 -0700, Andrew Morton wrote: > +/* Flags that should be inherited by new inodes from their parent. */ > +#define EXT2_FL_INHERITED ~(EXT2_DIRTY_FL | EXT2_ECOMPR_FL | EXT2_BTREE_FL |\ > + EXT2_INDEX_FL | EXT2_IMAGIC_FL | EXT2_TOPDIR_FL) This doesn't make things much better, unless it is just as a stop-gap measure to get into the kernel while there is more discussion about which flags need to be inherited... Duane did mention follow-up patches, so I have no real objection to this patch as-is, so long as we don't consider the matter closed. Minor nit - "EXT2_BTREE_FL" is the long-deprecated name for "EXT2_INDEX_FL", so we may as well just avoid it entirely here. Yes, this patch avoids a few more of the cases that are bad, but will again be incorrect as soon as some new flag enters use. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists