linux-ext4 - Re: Patches for the patchqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20080605185148.GY2961@webber.adilger.int>
Date:	Thu, 05 Jun 2008 12:51:48 -0600
From:	Andreas Dilger <adilger@....com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	Mingming Cao <cmm@...ibm.com>, Theodore Tso <tytso@....edu>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: Patches for the patchqueue

On Jun 05, 2008  15:23 +0530, Aneesh Kumar K.V wrote:
> vfs: Don't flush delay buffer to disk
> 
> In block_write_full_page() error case, we need to check the
> delayed flag before flush bh to disk when trying to recover from
> error.

> @@ -1775,7 +1775,8 @@ static int __block_write_full_page(struct inode *inode, struct page *page,
>  	bh = head;
>  	/* Recovery: lock and submit the mapped buffers */
>  	do {
> -		if (buffer_mapped(bh) && buffer_dirty(bh)) {
> +		if (buffer_mapped(bh) && buffer_dirty(bh)
> +			&& !buffer_delay(bh)) {

Please use proper CodingStyle here.  Firstly, this can fit on the previous
line < 80 columns so it shouldn't be split.  Secondly, if the line had to
be split, the "&&" should go at the end of the previous line.  Thirdly,
the continued line should align with the 'if (' on the previous line.


Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html