lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <200806092349.m59NnMZh015687@imap1.linux-foundation.org> Date: Mon, 09 Jun 2008 16:49:22 -0700 From: akpm@...ux-foundation.org To: tytso@....edu Cc: cmm@...ibm.com, akpm@...ux-foundation.org, jbacik@...hat.com, adilger@....com, linux-ext4@...r.kernel.org Subject: [patch (for 2.6.26?) 1/1] ext4: fix online resize bug From: Josef Bacik <jbacik@...hat.com> There is a bug when we are trying to verify that the reserve inode's double indirect blocks point back to the primary gdt blocks. The fix is obvious, we need to mod the gdb count by the addr's per block. This was verified using the same testcase as with the ext3 equivalent of this patch. Signed-off-by: Josef Bacik <jbacik@...hat.com> Cc: <linux-ext4@...r.kernel.org> Acked-by: Andreas Dilger <adilger@....com> Cc: Mingming Cao <cmm@...ibm.com> Acked-by: Theodore Ts'o <tytso@....edu> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> --- fs/ext4/resize.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN fs/ext4/resize.c~ext4-fix-online-resize-bug fs/ext4/resize.c --- a/fs/ext4/resize.c~ext4-fix-online-resize-bug +++ a/fs/ext4/resize.c @@ -563,7 +563,8 @@ static int reserve_backup_gdb(handle_t * } blk = EXT4_SB(sb)->s_sbh->b_blocknr + 1 + EXT4_SB(sb)->s_gdb_count; - data = (__le32 *)dind->b_data + EXT4_SB(sb)->s_gdb_count; + data = (__le32 *)dind->b_data + (EXT4_SB(sb)->s_gdb_count % + EXT4_ADDR_PER_BLOCK(sb)); end = (__le32 *)dind->b_data + EXT4_ADDR_PER_BLOCK(sb); /* Get each reserved primary GDT block and verify it holds backups */ _ -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists