linux-ext4 - Re: [PATCH -v2] ext4: Use inode preallocation with -o noextents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20080612093431.GZ3726@webber.adilger.int>
Date:	Thu, 12 Jun 2008 03:34:31 -0600
From:	Andreas Dilger <adilger@....com>
To:	Shen Feng <shen@...fujitsu.com>
Cc:	Mingming Cao <cmm@...ibm.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	Theodore Tso <tytso@....edu>, sandeen@...hat.com,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH -v2] ext4: Use inode preallocation with -o noextents

On Jun 11, 2008  11:26 +0800, Shen Feng wrote:
> Andreas Dilger Wrote:
> > On Jun 05, 2008  07:55 -0700, Mingming Cao wrote:
> >>>  /**
> >>> - * ext4_new_blocks_old() -- core block(s) allocation function
> >>> + * ext4_orlov_new_blocks() -- core block(s) allocation function
> >> what is orlov means? this is core function for non extent based without
> >> mballoc block allocation, right? 
> > 
> > Orlov is the name of the INODE allocator, not the block allocator.  I'm
> > not sure there is a name for the block allocator except "old" or "bitmap".
> > In the future I suspect we won't want to keep this version at all, using
> > the mballoc allocator even for block-mapped files, but it is useful for
> > now for performance comparisons.
> > 
> 
> Is that true?
> 
> I got the following from the kernel ext4 documentation.
> orlov		(*)	This enables the new Orlov block allocator. It is
> 			enabled by default.
> 
> oldalloc		This disables the Orlov block allocator and enables
> 			the old block allocator.  Orlov should have better
> 			performance - we'd like to get some feedback if it's
> 			the contrary for you.

The documentation is incorrect then.  The Orlov allocator is for inodes:

ialloc.c:
/*
 * Orlov's allocator for directories.
 
struct inode *ext3_new_inode(handle_t *handle, struct inode * dir, int mode)
{
        if (S_ISDIR(mode)) {
		if (test_opt (sb, OLDALLOC))
			group = find_group_dir(sb, dir);
		else
			group = find_group_orlov(sb, dir);


Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html