| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1213280041.9222.7.camel@localhost> Date: Thu, 12 Jun 2008 16:14:01 +0200 From: Frédéric Bohé <frederic.bohe@...l.net> To: tytso <tytso@....edu>, linux-ext4 <linux-ext4@...r.kernel.org> Subject: Re: [PATCH v3] ext4: fix online resize group descriptors corruption There was a tab issue in the v2 patch, sorry for the spam... From: Frederic Bohe <frederic.bohe@...l.net> This is the patch for the group descriptor table corruption during online resize pointed out by Theodore Tso. The issue was due to the ext4 group descriptor which can be either 32 or 64 bytes long. Only the 64 bytes structure was taken into account.t. Signed-off-by: Frederic Bohe <frederic.bohe@...l.net> --- resize.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -rup a/fs/ext4/resize.c b/fs/ext4/resize.c --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -855,7 +855,8 @@ int ext4_group_add(struct super_block *s */ /* Update group descriptor block for new group */ - gdp = (struct ext4_group_desc *)primary->b_data + gdb_off; + gdp = (struct ext4_group_desc *)((char *)primary->b_data + + gdb_off * EXT4_DESC_SIZE(sb)); ext4_block_bitmap_set(sb, gdp, input->block_bitmap); /* LV FIXME */ ext4_inode_bitmap_set(sb, gdp, input->inode_bitmap); /* LV FIXME */ -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists