lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <1213298827.6382.2.camel@norville.austin.ibm.com> Date: Thu, 12 Jun 2008 14:27:07 -0500 From: Dave Kleikamp <shaggy@...ux.vnet.ibm.com> To: Duane Griffin <duaneg@...da.com> Cc: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>, akpm@...ux-foundation.org, Andreas Dilger <adilger@....com>, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 6/6] ext4: tighten restrictions on inode flags On Wed, 2008-06-11 at 12:49 +0100, Duane Griffin wrote: > 2008/6/11 Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>: > >> +/* Mask out flags that are inappropriate for the given type of inode. */ > >> +static inline __le32 ext4_mask_flags(__le16 mode, __le32 flags) > >> +{ > >> + if (S_ISDIR(mode)) > >> + return flags; > >> + else if (S_ISREG(mode)) > >> + return flags & ~EXT4_REG_FLMASK; > >> + else > >> + return flags & ~EXT4_OTHER_FLMASK; > >> +} > >> + > > > > why are the arguments __le32 ? They should be in host order. > > > > static inline __u32 ext4_mask_flags(umode_t mode, __u32 flags) > > Whoops, I was matching the fields in ex4_inode, but I should have been > looking at ext4_inode_info. Shouldn't sparse have complained about > that? It does, but not by default. You need to run sparse with -D__CHECK_ENDIAN__ I use this alias: make_sparse is aliased to `make C=2 CF="-D__CHECK_ENDIAN__"' Shaggy -- David Kleikamp IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists