lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 16 Jun 2008 17:39:35 +0900
From:	Akira Fujita <a-fujita@...jp.nec.com>
To:	Shen Feng <shen@...fujitsu.com>
CC:	linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Theodore Tso <tytso@....edu>, Mingming Cao <cmm@...ibm.com>
Subject: Re: [RFC][PATCH 7/8]ext4: move victim files for the target file (-f
 mode)

Shen Feng Wrote:
> 
> Akira Fujita Wrote:
>> ext4: online defrag-- Move victim files for the target file (-f mode)
>>
>> From: Akira Fujita <a-fujita@...jp.nec.com>
>>
>> Move victim files to make sufficient space and reallocates
>> the contiguous blocks for the target file.
>>
>> Signed-off-by: Akira Fujita <a-fujita@...jp.nec.com>
>> Signed-off-by: Takashi Sato <t-sato@...jp.nec.com>
>> ---
>>  fs/ext4/balloc.c       |   10 +-
>>  fs/ext4/defrag.c       |  460 +++++++++++++++++++++++++++++++++++++++++++++---
>>  fs/ext4/ext4.h         |   29 +++-
>>  fs/ext4/ext4_extents.h |    5 +
>>  fs/ext4/extents.c      |   54 +++++--
>>  fs/ext4/ioctl.c        |    5 +-
>>  fs/ext4/mballoc.c      |    5 +
>>  fs/ext4/mballoc.h      |    1 +
>>  8 files changed, 522 insertions(+), 47 deletions(-)
>>
> 
> ...snip...
> 
>> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
>> index d0b1301..88fd100 100644
>> --- a/fs/ext4/ext4.h
>> +++ b/fs/ext4/ext4.h
>> @@ -94,6 +94,11 @@ struct ext4_allocation_request {
>>  	unsigned long len;
>>  	/* flags. see above EXT4_MB_HINT_* */
>>  	unsigned long flags;
>> +	/*
>> +	 * for ext4 online defrag:
>> +	 * the block group which is excepted from allocation target
>> +	 */
>> +	long long excepted_group;
>>  };
> 
> Why not ext4_group_t for excepted_group here?

ac_excepted_group has not only excepted block group number
but also -1 (it means any block groups are accepted).
So we should keep it as long long variable to show
the special status correctly in large ext4.

Regards,
Akira Fujita
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists