linux-ext4 - Re: [PATCH 1/2] sync up block & inode bitmap reading functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <20080721051209.GL3370@webber.adilger.int>
Date:	Sun, 20 Jul 2008 23:12:09 -0600
From:	Andreas Dilger <adilger@....com>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 1/2] sync up block & inode bitmap reading functions

On Jul 18, 2008  14:52 -0500, Eric Sandeen wrote:
> @@ -97,34 +97,41 @@ unsigned ext4_init_inode_bitmap(struct s
>  static struct buffer_head *
> -read_inode_bitmap(struct super_block *sb, ext4_group_t block_group)
> +ext4_read_inode_bitmap(struct super_block *sb, ext4_group_t block_group)
>  {
>  	struct ext4_group_desc *desc;
>  	struct buffer_head *bh = NULL;
> +	ext4_fsblk_t bitmap_blk;
>  
>  	desc = ext4_get_group_desc(sb, block_group, NULL);
>  	if (!desc)
> +		return NULL;

If you were feeling generous, you could change this function to take
gdp as a parameter (or post it as a kernel janitor task?), because
it is already available in most of the functions that call
read_{block,inode}_bitmap(), with the exception of ext4_orphan_get().

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html