linux-ext4 - Re: [PATCH] missing journal_stop in ext4_da_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Jul 2008 11:09:45 -0700
From:	Mingming Cao <cmm@...ibm.com>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] missing journal_stop in ext4_da_write_begin error case


在 2008-07-31四的 12:23 -0500，Eric Sandeen写道：
> ext4_da_write_begin needs to call journal_stop before returning,
> if the page allocation fails.
> 
> Signed-off-by: Eric Sandeen <sandeen@...hat.com>
Ackd-by: Mingming Cao <cmm@...ibm.com>

> ---
> 
> Index: linux-2.6/fs/ext4/inode.c
> ===================================================================
> --- linux-2.6.orig/fs/ext4/inode.c	2008-07-29 17:18:26.000000000 -0500
> +++ linux-2.6/fs/ext4/inode.c	2008-07-31 12:21:03.866229084 -0500
> @@ -2280,8 +2280,11 @@ retry:
>  	}
> 
>  	page = __grab_cache_page(mapping, index);
> -	if (!page)
> -		return -ENOMEM;
> +	if (!page) {
> +		ext4_journal_stop(handle);
> +		ret = -ENOMEM;
> +		goto out;
> +	}
>  	*pagep = page;
> 
>  	ret = block_write_begin(file, mapping, pos, len, flags, pagep, fsdata,
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html