lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080801023358.GC8736@mit.edu> Date: Thu, 31 Jul 2008 22:33:59 -0400 From: Theodore Tso <tytso@....edu> To: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> Cc: Ext4 Developers List <linux-ext4@...r.kernel.org>, sugita <yumiko.sugita.yf@...achi.com>, Satoshi OSHIMA <satoshi.oshima.fk@...achi.com> Subject: Re: [PATCH] jbd2: don't abort if flushing file data failed On Thu, Jul 31, 2008 at 03:00:32PM +0900, Hidehiro Kawai wrote: > I tested this patch on 2.6.27-rc1, but it didn't work properly. > Then, I noticed two mistakes. > > (1) journal_submit_data_buffers() just submits I/Os, doesn't wait > their completion. We have to check file data write errors > after calling journal_finish_inode_data_buffers() > (2) AS_EIO is cleared by wait_on_page_writeback_range(), so we > have to set it again Thank you very much for catching these errors; you are very correct! > I attached the revised patch below. journal_submit_data_buffers() > can return error, but it wouldn't be write I/O error AFAIK, so I > didn't touched. I've replaced the patch with your revised patch in the ext4 patch queue; thanks again for double-checking the patch and offering the revised version. Many thanks, - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists