linux-ext4 - [PATCH] ext4: don't try to resize if there are no reserved gdt blocks left

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20080806161656.GG27394@unused.rdu.redhat.com>
Date:	Wed, 6 Aug 2008 12:16:56 -0400
From:	Josef Bacik <jbacik@...hat.com>
To:	linux-ext4@...r.kernel.org
Subject: [PATCH] ext4: don't try to resize if there are no reserved gdt
	blocks left

Hello,

When trying to resize a ext3 fs and you run out of reserved gdt blocks, you get
an error that doesn't actually tell you what went wrong, it just says that the
gdb it picked is not correct, which is the case since you don't have any
reserved gdt blocks left.  This patch adds a check to make sure you have
reserved gdt blocks to use, and if not prints out a more relevant error.  Thank
you,

Signed-off-by: Josef Bacik <jbacik@...hat.com>

Index: linux-2.6/fs/ext4/resize.c
===================================================================
--- linux-2.6.orig/fs/ext4/resize.c
+++ linux-2.6/fs/ext4/resize.c
@@ -773,7 +773,8 @@ int ext4_group_add(struct super_block *s
 
 	if (reserved_gdb || gdb_off == 0) {
 		if (!EXT4_HAS_COMPAT_FEATURE(sb,
-					     EXT4_FEATURE_COMPAT_RESIZE_INODE)){
+					     EXT4_FEATURE_COMPAT_RESIZE_INODE)
+		    || !le16_to_cpu(es->s_reserved_gdt_blocks)){
 			ext4_warning(sb, __func__,
 				     "No reserved GDT blocks, can't resize");
 			return -EPERM;
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html