| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1218144881.6569.14.camel@mingming-laptop>
Date: Thu, 07 Aug 2008 14:34:41 -0700
From: Mingming Cao <cmm@...ibm.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc: tytso@....edu, sandeen@...hat.com, linux-ext4@...r.kernel.org
Subject: Re: [RFC PATCH] ext4: invalidate pages if delalloc block
allocation fails.
Aneesh,
> This patch is for review only. I will redo this and the last
> da_writepages patch splitting it into three patches later as below.
>
> a) handle unwritten extent
> b) redo da_writepages
> c) handle block allocation failure.
>
> We are a bit agressive in invalidating all the pages. But
> it is ok because we really don't know why the block allocation
> failed and it is better to come of the writeback path
> so that user can look for more info.
>
So right now, without you patch below, if delayed allocation block
allocation failed, the pages are redirtied, and umount don't know how
to handle those dirty pages, and those data will lost, is this right?
With this patch, if the block allocation failed, since you now
invalidate all the pages immediately, I am afraid we lost the chance to
retry and just let the page/data gone?
Maybe we should retry a bit in case of get_block failed with
ENOSPC(shouldn;t happen with block reservation, but just in case..),
and, not sure how hard to do, reduce the contigous extent size, and try
to allocate a smaller chunk of new blocks?
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> ---
> fs/ext4/inode.c | 80 ++++++++++++++++++++++++++++++++++++++++++++++++++-----
> 1 files changed, 73 insertions(+), 7 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 368ec6b..14dc9b0 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -1629,7 +1629,12 @@ static int mpage_da_submit_io(struct mpage_da_data *mpd)
> int ret = 0, err, nr_pages, i;
> unsigned long index, end;
> struct pagevec pvec;
> -
> + struct mpage_data mpd_pp = {
> + .bio = NULL,
> + .last_block_in_bio = 0,
> + .get_block = mpd->get_block,
> + .use_writepage = 1,
> + };
> BUG_ON(mpd->next_page <= mpd->first_page);
>
> pagevec_init(&pvec, 0);
> @@ -1649,10 +1654,9 @@ static int mpage_da_submit_io(struct mpage_da_data *mpd)
> break;
> index++;
>
> - err = mapping->a_ops->writepage(page, mpd->wbc);
> + err = __mpage_writepage(page, mpd->wbc, &mpd_pp);
> if (!err)
> mpd->pages_written++;
> -
> /*
> * In error case, we have to continue because
> * remaining pages are still locked
> @@ -1663,6 +1667,8 @@ static int mpage_da_submit_io(struct mpage_da_data *mpd)
> }
> pagevec_release(&pvec);
> }
> + if (mpd_pp.bio)
> + mpage_bio_submit(WRITE, mpd_pp.bio);
>
> return ret;
> }
> @@ -1686,7 +1692,7 @@ static void mpage_put_bnr_to_bhs(struct mpage_da_data *mpd, sector_t logical,
> int blocks = exbh->b_size >> inode->i_blkbits;
> sector_t pblock = exbh->b_blocknr, cur_logical;
> struct buffer_head *head, *bh;
> - unsigned long index, end;
> + pgoff_t index, end;
> struct pagevec pvec;
> int nr_pages, i;
>
> @@ -1763,6 +1769,39 @@ static inline void __unmap_underlying_blocks(struct inode *inode,
> unmap_underlying_metadata(bdev, bh->b_blocknr + i);
> }
>
> +static void ext4_da_block_invalidatepages(struct mpage_da_data *mpd,
> + sector_t logical, long blk_cnt)
> +{
> + int nr_pages, i;
> + pgoff_t index, end;
> + struct pagevec pvec;
> + struct inode *inode = mpd->inode;
> + struct address_space *mapping = inode->i_mapping;
> +
> + index = logical >> (PAGE_CACHE_SHIFT - inode->i_blkbits);
> + end = (logical + blk_cnt - 1) >>
> + (PAGE_CACHE_SHIFT - inode->i_blkbits);
> + while (index <= end) {
> + nr_pages = pagevec_lookup(&pvec, mapping, index, PAGEVEC_SIZE);
> + if (nr_pages == 0)
> + break;
> + for (i = 0; i < nr_pages; i++) {
> + struct page *page = pvec.pages[i];
> + index = page->index;
> + if (index > end)
> + break;
> + index++;
> +
> + BUG_ON(!PageLocked(page));
> + BUG_ON(PageWriteback(page));
> + block_invalidatepage(page, 0);
> + ClearPageUptodate(page);
> + unlock_page(page);
> + }
> + }
> + return;
> +}
> +
> /*
> * mpage_da_map_blocks - go through given space
> *
> @@ -1798,8 +1837,35 @@ static void mpage_da_map_blocks(struct mpage_da_data *mpd)
> if (!new.b_size)
> return;
> err = mpd->get_block(mpd->inode, next, &new, 1);
> - if (err)
> + if (err) {
> +
> + /* If get block returns with error
> + * we simply return. Later writepage
> + * will redirty the page and writepages
> + * will find the dirty page again
> + */
> + if (err == -EAGAIN)
> + return;
> + /*
> + * get block failure will cause us
> + * to loop in writepages. Because
> + * a_ops->writepage won't be able to
> + * make progress. The page will be redirtied
> + * by writepage and writepages will again
> + * try to write the same.
> + */
> + printk(KERN_EMERG "%s block allocation failed for inode %lu "
> + "at logical offset %llu with max blocks "
> + "%zd with error %d\n",
> + __func__, mpd->inode->i_ino,
> + (unsigned long long)next,
> + lbh->b_size >> mpd->inode->i_blkbits, err);
> +
> + /* invlaidate all the pages */
> + ext4_da_block_invalidatepages(mpd, next,
> + lbh->b_size >> mpd->inode->i_blkbits);
> return;
> + }
A little more comments about why we have to invalidate all the pages,
and impact of doing so would be helpful. Also it would nice to add a
warning message of data lost.
> BUG_ON(new.b_size == 0);
>
> if (buffer_new(&new))
> @@ -2267,8 +2333,8 @@ static int ext4_da_writepages(struct address_space *mapping,
> handle = ext4_journal_start(inode, needed_blocks);
> if (IS_ERR(handle)) {
> ret = PTR_ERR(handle);
> - printk(KERN_EMERG "ext4_da_writepages: jbd2_start: "
> - "%ld pages, ino %lu; err %d\n",
> + printk(KERN_EMERG "%s: jbd2_start: "
> + "%ld pages, ino %lu; err %d\n", __func__,
> wbc->nr_to_write, inode->i_ino, ret);
> dump_stack();
> goto out_writepages;
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists