linux-ext4 - Re: [PATCH] blkid: optimize dm_device_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080827081000.GO6029@nb.net.home>
Date:	Wed, 27 Aug 2008 10:10:01 +0200
From:	Karel Zak <kzak@...hat.com>
To:	Andreas Dilger <adilger@....com>
Cc:	Theodore Tso <tytso@....edu>, linux-ext4@...r.kernel.org,
	Eric Sandeen <sandeen@...hat.com>, mbroz@...hat.com,
	agk@...hat.com
Subject: Re: [PATCH] blkid: optimize dm_device_is_leaf() usage

On Wed, Aug 27, 2008 at 01:26:43AM -0600, Andreas Dilger wrote:
> On Aug 27, 2008  02:19 +0200, Karel Zak wrote:
> > On Tue, Aug 26, 2008 at 07:32:25PM -0400, Theodore Tso wrote:
> > > you'll just be re-inventing blkid.  If you don't cache, you'll either
> > 
> >  Hehe.. I will directly copy code from blkid and vol_id. It's open
> >  source. I needn't re-inventing ;-)
> 
> Couldn't you just change libblkid to export the probe functions?  It
> always makes me cringe when code like this is copied, because I just
> _know_ one or the other will become out of date, and it will take
> twice as much effort to keep them in sync.  I'd rather see people
> doing "high value" work instead of watching for and copying patches
> around.

 Yes, good point. Frankly, I think about it in last weeks. I have done
 work on the low-lever part of libfsprobe -- it shouldn't be a problem
 port this code to libblkid. The advantage will be a library that is
 usable for udev and backwardly compatible for the current blkid
 applications. I will try it...

    Karel

-- 
 Karel Zak  <kzak@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html