linux-ext4 - Re: Do we need dump for ext4?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20080828231406.GT3392@webber.adilger.int>
Date:	Thu, 28 Aug 2008 17:14:06 -0600
From:	Andreas Dilger <adilger@....com>
To:	Theodore Tso <tytso@....edu>
Cc:	Ric Wheeler <rwheeler@...hat.com>,
	Eric Sandeen <sandeen@...hat.com>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: Do we need dump for ext4?

On Aug 28, 2008  18:34 -0400, Theodore Ts'o wrote:
> It's fine, because according to POSIX it's undefined what happens to
> files that are created or deleted after the last opendir() or
> rewindir().  So basically, the b-tree is attached to the opendir, and
> we discard it and re-create it if we ever seek to the beginning of the
> directory.

... presumably only if the directory has been modified in the meantime?
It seems like this is missing from the ext3_dx_readdir() code, and could
be easily achieved by checking inode->i_version vs. filp->f_version or
similar.  It looks like this is checked later on, but by that time we've
already discarded everything.


Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html