linux-ext4 - Re: Do we need dump for ext4?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080829141703.GC30887@mit.edu>
Date:	Fri, 29 Aug 2008 10:17:03 -0400
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>,
	Ric Wheeler <rwheeler@...hat.com>
Subject: Re: Do we need dump for ext4?

Just for completeness's sake, can you apply the following patch to
dump, and then try doing a benchmark run using dump on ext4?

I'm curious how it would compare.

      	       	   	   	     	       - Ted

Index: dump-0.4b41/dump/traverse.c
===================================================================
--- dump-0.4b41.orig/dump/traverse.c
+++ dump-0.4b41/dump/traverse.c
@@ -157,14 +157,6 @@ int dump_fs_open(const char *disk, ext2_
 			retval = EXT2_ET_UNSUPP_FEATURE;
 			ext2fs_close(*fs);
 		}
-		else if ((retval = es->s_feature_incompat &
-					~(EXT2_LIB_FEATURE_INCOMPAT_SUPP |
-					  EXT3_FEATURE_INCOMPAT_RECOVER))) {
-			msg("Unsupported feature(s) 0x%x in filesystem\n",
-				retval);
-			retval = EXT2_ET_UNSUPP_FEATURE;
-			ext2fs_close(*fs);
-		}
 		else {
 			if (es->s_feature_compat &
 				EXT3_FEATURE_COMPAT_HAS_JOURNAL && 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html