linux-ext4 - Re: [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more carefully

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080907160414.GB26248@charite.de>
Date:	Sun, 7 Sep 2008 18:04:14 +0200
From:	Ralf Hildebrandt <Ralf.Hildebrandt@...rite.de>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Andreas Dilger <adilger@....com>, akpm@...l.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more
	carefully

* Alexey Dobriyan <adobriyan@...il.com>:

> > Why not use strchr(), which is normally optimized assembly:
> > 
> > 	char *p = devname;
> > 	while ((p = strchr(p, '/'))
> > 		*p = '_';
> > 
> > Using '!' as the separator makes it harder to use from shells I suspect,
> > so I'd suggest '_' instead.
> 
> bdevname is only 32 bytes and done once per mount, so nobody cares.
> 
> '!' is what other code does in this situation (reiserfs, md, ...).

Anyway, the first patch fixes the issue. Will it go into mainline soon?

-- 
Ralf Hildebrandt (i.A. des IT-Zentrums)         Ralf.Hildebrandt@...rite.de
Charite - Universitätsmedizin Berlin            Tel.  +49 (0)30-450 570-155
Gemeinsame Einrichtung von FU- und HU-Berlin    Fax.  +49 (0)30-450 570-962
IT-Zentrum Standort CBF                              I'm looking for a job!
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html