linux-ext4 - Re: [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more carefully

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080907164130.GA3376@x200.localdomain>
Date:	Sun, 7 Sep 2008 20:41:30 +0400
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Theodore Tso <tytso@....EDU>
Cc:	Ralf Hildebrandt <Ralf.Hildebrandt@...rite.de>,
	Andreas Dilger <adilger@....com>, akpm@...l.org,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH] ext4: fix #11321: create /proc/ext4/*/stats et al more
	carefully

On Sun, Sep 07, 2008 at 12:24:47PM -0400, Theodore Tso wrote:
> On Sun, Sep 07, 2008 at 04:15:57PM +0400, Alexey Dobriyan wrote:
> > > Why not use strchr(), which is normally optimized assembly:
> > > 
> > > 	char *p = devname;
> > > 	while ((p = strchr(p, '/'))
> > > 		*p = '_';
> > > 
> > > Using '!' as the separator makes it harder to use from shells I suspect,
> > > so I'd suggest '_' instead.
> > 
> > bdevname is only 32 bytes and done once per mount, so nobody cares.
> 
> Bloat gets inserted into the kernel, 32 bytes at a time.  :-)

You mean, one filesystem at time. ;-)

> > '!' is what other code does in this situation (reiserfs, md, ...).
> 
> I'm not convinced that the consistency is as important in this case as
> making it easy for people using shells typing the pathname...

A what?

	mkdir z\!ext4
	ls z[Tab]\!ext4

As for underscore, use '-' if you really care about typing.
One Shift less.

register_disk() uses '!' too, BTW.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html