lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 08 Sep 2008 16:20:58 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Theodore Tso <tytso@....EDU>
CC:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] make all feature-related printks KERN_INFO and print
 barrier status as well

Theodore Tso wrote:
> On Mon, Sep 08, 2008 at 12:08:30PM -0500, Eric Sandeen wrote:
>> A very trivial little tidy-up patch.
>>
>> This slightly duplicates a little of
>> patches/ext4_fix_printk_checkpatch_issues but just in one hunk,
>> easily fixed up.
>>
>> Various feature printk's come out at different levels, so for example
>> at my default logging level I see mballoc & extents messages, but
>> not delalloc, even though they are all on.
>>
>> Also, since default barrier behavior has changed, I thought perhaps always
>> printing the barrier state might be a good idea.
> 
> Looks good to me.  Any reason not to merge it with the
> ext4_fix_printk_checkpatches_issues?  Actually what I was thinking
> about doing was to segregate out all of the printk level issues from
> everything else, just to make it easier to understand/audit the
> cleanup patch(es).
> 
> 							- Ted

Sure, it could be merged.  The patch I sent actually changed some
behavior, and was limited to mount-time feature prints, so thought it
might make sense on its own.

Either way is fine by me.

-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ