linux-ext4 - Re: [PATCH] include <linux/fs.h> into linux/ext2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080910114923.GC3757@localhost.localdomain>
Date:	Wed, 10 Sep 2008 14:49:24 +0300
From:	"Kirill A. Shutemov" <kirill@...temov.name>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-ext4@...r.kernel.org, David Howells <dhowells@...hat.com>,
	Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] include <linux/fs.h> into linux/ext2_fs.h

On Wed, Sep 10, 2008 at 07:40:42AM -0400, Christoph Hellwig wrote:
> On Wed, Sep 10, 2008 at 02:40:12PM +0300, Kirill A. Shutemov wrote:
> > On Wed, Sep 10, 2008 at 07:27:09AM -0400, Christoph Hellwig wrote:
> > > On Wed, Sep 10, 2008 at 02:22:03PM +0300, Kirill A. Shutemov wrote:
> > > > linux/fs.h defines FS_IOC* needed by linux/ext2_fs.h
> > > 
> > > And who cares?  

Do you think it isn't error?

> > It breaks building pam_mktemp at least.
> 
> pam_mktemp should not use <linux/ext2_fs.h>, but rather
> <ext2fs/ext2_fs.h>.

Why linux/ext2_fs.h does export to userspace?


-- 
Regards,  Kirill A. Shutemov
 + Belarus, Minsk
 + ALT Linux Team, http://www.altlinux.com/

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)