linux-ext4 - Re: [PATCH updated] ext4: Fix file fragmentation during large file write.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081016024141.GA15487@mit.edu>
Date:	Wed, 15 Oct 2008 22:41:41 -0400
From:	Theodore Tso <tytso@....edu>
To:	Chris Mason <chris.mason@...cle.com>
Cc:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
	cmm@...ibm.com, sandeen@...hat.com, akpm@...ux-foundation.org,
	hch@...radead.org, steve@...gwyn.com, npiggin@...e.de,
	mpatocka@...hat.com, linux-mm@...ck.org,
	inux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH updated] ext4: Fix file fragmentation during large file
	write.

On Wed, Oct 15, 2008 at 07:51:32PM -0400, Chris Mason wrote:
> 
> Just FYI, I ran this with compilebench -i 20 --makej and my log is full
> of these:
> 
> ext4_da_writepages: jbd2_start: 1024 pages, ino 520417; err -30
> Pid: 4072, comm: pdflush Not tainted 2.6.27 #2

That's from ext4_journal_start_sb:

       if (sb->s_flags & MS_RDONLY)
       	  return ERR_PTR(-EROFS);

What was the very first error in your log?  It looks like ext4 somehow
flagged some kind of filesystem error or aborted the journal due to
some failure, and log gets filled these messages.  We should probably 
should throttle these messages by simply putting a

       if (sb->s_flags & MS_RDONLY)
		return -ERNOFS;

at the beginning of ext4_da_writepages() so we don't fill the logs
with extraneous messages that obscure more important error messages.

     			      	      	   	     - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html