| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200810190327.m9J3Rrw7032702@imap1.linux-foundation.org> Date: Sat, 18 Oct 2008 20:27:53 -0700 From: akpm@...ux-foundation.org To: torvalds@...ux-foundation.org Cc: akpm@...ux-foundation.org, hidehiro.kawai.ez@...achi.com, jack@...e.cz, linux-ext4@...r.kernel.org Subject: [patch 088/148] jbd: abort when failed to log metadata buffers From: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> If we failed to write metadata buffers to the journal space and succeeded to write the commit record, stale data can be written back to the filesystem as metadata in the recovery phase. To avoid this, when we failed to write out metadata buffers, abort the journal before writing the commit record. Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@...achi.com> Acked-by: Jan Kara <jack@...e.cz> Cc: <linux-ext4@...r.kernel.org> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> --- fs/jbd/commit.c | 3 +++ 1 file changed, 3 insertions(+) diff -puN fs/jbd/commit.c~jbd-abort-when-failed-to-log-metadata-buffers fs/jbd/commit.c --- a/fs/jbd/commit.c~jbd-abort-when-failed-to-log-metadata-buffers +++ a/fs/jbd/commit.c @@ -762,6 +762,9 @@ wait_for_iobuf: /* AKPM: bforget here */ } + if (err) + journal_abort(journal, err); + jbd_debug(3, "JBD: commit phase 6\n"); if (journal_write_commit_record(journal, commit_transaction)) _ -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists