| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Oct 2008 14:50:59 -0700
From: Daniel Phillips <phillips@...nq.net>
To: Theodore Ts'o <tytso@....edu>
Cc: Ext4 Developers List <linux-ext4@...r.kernel.org>,
akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH,RFC] ext3: Add support for non-native signed/unsigned htree hash algorithms
On Monday 20 October 2008 20:43, Theodore Ts'o wrote:
> +static __u32 dx_hack_hash (const char *name, int len, int unsigned_flag)
> ...
> + if (unsigned_flag)
> + c = (int) *ucp++;
> + else
> + c = (int) *scp++;
This being a high performance hash function and all, why not something
like:
+static __u32 uchar_hack_hash (const char *name, int len)
+...
+static __u32 char_hack_hash (const char *name, int len)
+...
+static __u32 dx_hack_hash(const char *name, int len, int unsigned_flag)
+{
+ if (unsigned_flag)
+ return uchar_hack_hash(name, len);
+ return char_hack_hash(name, len);
+}
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists