linux-ext4 - Re: [PATCH,RFC] ext3: Add support for non-native signed/unsigned htree hash algorithms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081022172221.c1a8c5b5.akpm@linux-foundation.org>
Date:	Wed, 22 Oct 2008 17:22:21 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Theodore Ts'o" <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org, tytso@....edu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH,RFC] ext3: Add support for non-native signed/unsigned
 htree hash algorithms

On Mon, 20 Oct 2008 23:43:44 -0400
"Theodore Ts'o" <tytso@....edu> wrote:

> +	i = le32_to_cpu(es->s_flags);
> +	if (i & EXT2_FLAGS_UNSIGNED_HASH)
> +		sbi->s_hash_unsigned = 3;
> +	else if ((i & EXT2_FLAGS_SIGNED_HASH) == 0) {
> +		char	c;
> +
> +		c = (char) 255;
> +		if (((int) c) == -1) {

arm says

fs/ext3/super.c: In function `ext3_fill_super':
fs/ext3/super.c:1750: warning: comparison is always false due to limited range of data type

Also, is there any way in which this new code can be, umm, cleaned up?
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html