lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 2 Nov 2008 22:39:20 -0500
From:	Theodore Tso <tytso@....edu>
To:	linux-ext4@...r.kernel.org
Cc:	Mingming Cao <cmm@...ibm.com>
Subject: Re: JBD2/ext4 error

On Sun, Nov 02, 2008 at 07:48:27PM -0500, Joseph Fannin wrote:
> Hi,
> 
> I'm hitting what's probably a bug in ext4 on one of my boxes. It
> always happens on the boot partition, which is extentless, since it
> seems likely GRUB will choke on extents.

Yeah, this looks like a 2.6.27 regression, introduced by commit a02908f1.

Mingming, can you check this:  I think in the function (in fs/ext4/inode.c):

static int ext4_index_trans_blocks(struct inode *inode, int nrblocks, int chunk)
{
	if (!(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL))
		return ext4_indirect_trans_blocks(inode, nrblocks, 0);
	return ext4_ext_index_trans_blocks(inode, nrblocks, 0);
}

... the last argument to ext4_indirect_trans_blocks and
ext4_ext_index_trans_blocks should be chunk, not 0.  

As result of this bug, we are massively overestimately the amount of
credits needed in the non-extent case, and with small journals, this
causes a failure.

We probably should do more testing with minimally sized journals to
make sure there aren't other problems which only show up with small
journals.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists