lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 4 Nov 2008 11:46:04 -0500
From:	Theodore Tso <tytso@....edu>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	cmm@...ibm.com, sandeen@...hat.com, linux-ext4@...r.kernel.org
Subject: Re: [RFC PATCH -v2 8/9] ext4: Fix double free of blocks

On Mon, Nov 03, 2008 at 11:06:08PM +0530, Aneesh Kumar K.V wrote:
> blocks freed but not yet committed will be marked free
> in disk bitmap. We need to consider them as used when
> releasing inode prealloc space. Otherwise we would
> double free them via mb_free_blocks

Stupid question...   

Blocks that are added to an inode's preallocation list were initially
free, right?  And once they are in the inode's preallocation they are
marked in use by mballoc, so they can't be allocated for another
inode.  If a block in the preallocation list is used, it's removed
from the preallocation line.  So even if that inode is subsequented
unlinked or truncated, I'm curious how the double free situation
happens in the first place.

What am I missing?

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists