linux-ext4 - Re: [PATCH -V2] ext4: Mark the buffer_heads as dirty and uptodate after prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081107133303.GA9543@mit.edu>
Date:	Fri, 7 Nov 2008 08:33:03 -0500
From:	Theodore Tso <tytso@....edu>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	cmm@...ibm.com, sandeen@...hat.com, vallesroc@...il.com,
	Solofo.Ramangalahy@...l.net, cryptooctoploid@...il.com,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH -V2] ext4: Mark the buffer_heads as dirty and uptodate
	after prepare_write

Per discussion on IRC, we've Aneesh and I have concluded that the V1
patch is correct, and in fact calling block_commit_write() when we
will be redirtying the page (a) can cause problems if one or more
buffer heads on the page is marked for delayed allocation and so
bh->block_nr is 0, and (b) wastes disk bandwidth since the page
contents will be potentially written out twice.

So we'll be going with the V1 version of the patch, and pushing it to
Linus ASAP.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html