linux-ext4 - + ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 16:34:46 -0800
From:	akpm@...ux-foundation.org
To:	mm-commits@...r.kernel.org
Cc:	tytso@....edu, linux-ext4@...r.kernel.org
Subject: + ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write_super.patch added to -mm tree


The patch titled
     ext3: Clean up outdated and incorrect comment for ext3_write_super()
has been added to the -mm tree.  Its filename is
     ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write_super.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: ext3: Clean up outdated and incorrect comment for ext3_write_super()
From: Theodore Tso <tytso@....edu>

Signed-off-by: "Theodore Ts'o" <tytso@....edu>
Cc: <linux-ext4@...r.kernel.org>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
---

 fs/ext3/super.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff -puN fs/ext3/super.c~ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write_super fs/ext3/super.c
--- a/fs/ext3/super.c~ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write_super
+++ a/fs/ext3/super.c
@@ -2375,12 +2375,9 @@ int ext3_force_commit(struct super_block
 /*
  * Ext3 always journals updates to the superblock itself, so we don't
  * have to propagate any other updates to the superblock on disk at this
- * point.  Just start an async writeback to get the buffers on their way
- * to the disk.
- *
- * This implicitly triggers the writebehind on sync().
+ * point.  (We can probably nuke this function altogether, and remove
+ * any mention to sb->s_dirt in all of fs/ext3; eventual cleanup...)
  */
-
 static void ext3_write_super (struct super_block * sb)
 {
 	if (mutex_trylock(&sb->s_lock) != 0)
_

Patches currently in -mm which might be from tytso@....edu are

ext3-clean-up-outdated-and-incorrect-comment-for-ext3_write_super.patch
linux-next.patch

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html