linux-ext4 - Re: [PATCH] filesystems: use has_capability_noaudit interface for reserved blocks checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1226676961.3353.78.camel@localhost.localdomain>
Date:	Fri, 14 Nov 2008 10:36:01 -0500
From:	Eric Paris <eparis@...hat.com>
To:	Artem Bityutskiy <dedekind@...dex.ru>
Cc:	linux-kernel@...r.kernel.org, sct@...hat.com,
	akpm@...ux-foundation.org, adilger@....com, tytso@....edu,
	linux-ext4@...r.kernel.org, dedekind@...radead.org,
	ext-adrian.hunter@...ia.com, linux-mtd@...ts.infradead.org,
	dushistov@...l.ru, jmorris@...ei.org
Subject: Re: [PATCH] filesystems: use has_capability_noaudit interface for
 reserved blocks checks

On Fri, 2008-11-14 at 09:55 +0200, Artem Bityutskiy wrote:
> Eric Paris wrote:
> > ext[2,3,4], ufs, and ubifs all check for  CAP_SYS_RESOURCE to determine
> > if they should allow reserved blocks to be used.  A process not having
> > this capability is not failing some security decision and should not be
> > audited.  Thus move to using has_capability_noaudit.
> > 
> > Signed-off-by: Eric Paris <eparis@...hat.com>
> > ---
> 
> UBIFS part looks OK, as long as the whole idea of the patch is right, which
> I have not checked, but assume it is.
> 
> The only question is are you sure exporting 'cap_capable()' is relevant
> to this patch? You do not seem to call it directly.

After this change, modules call has_capability_noaudit() which is a
#define which turns this into modules calling
security_capable_noaudit().  You noticed this and decided it was correct
to make that export.  But when CONFIG_SECURITY is not set
security_capable_notaudit() is a static inline which calls
cap_capable().  See include/linux/security.h line 2832 in the linux-next
tree.  Now modules are calling cap_capable directly, thus the export.

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html