linux-ext4 - PATCH ext4: fix to call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081124182105.184338C977@localhost>
Date:	Mon, 24 Nov 2008 10:21:05 -0800 (PST)
From:	curtw@...gle.com (Curt Wohlgemuth)
To:	linux-ext4@...r.kernel.org
Subject: PATCH ext4: fix to call_filldir

[ Sorry: I mistakenly sent just the patch, with no explanation... ]

I happened to find a bug running bonnie++-1.03a on an ext4 filesystem, when
it complained about not being able to remove a file.

Further investigation showed a problem with call_filldir(), which is not
quite correct with respect to the same function in fs/ext3/dir.c.  The patch
below fixes this problem.

Signed-off-by: Curt Wohlgemuth <curtw@...gle.com>

---

diff -Naur ext4/fs/ext4/dir.c b/fs/ext4/dir.c
--- ext4/fs/ext4/dir.c	2008-11-13 14:51:58.000000000 -0800
+++ b/fs/ext4/dir.c	2008-11-24 08:23:05.000000000 -0800
@@ -417,7 +417,7 @@
 				get_dtype(sb, fname->file_type));
 		if (error) {
 			filp->f_pos = curr_pos;
-			info->extra_fname = fname;
+			info->extra_fname = fname->next;
 			return error;
 		}
 		fname = fname->next;
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html