linux-ext4 - Re: [PATCH 1/2] ext4: Fix the delalloc writepages to allocate blocks at the right offset.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Nov 2008 11:07:26 +0530
From:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	Theodore Tso <tytso@....edu>
Cc:	cmm@...ibm.com, sandeen@...hat.com, vallesroc@...il.com,
	Solofo.Ramangalahy@...l.net, cryptooctoploid@...il.com,
	linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/2] ext4: Fix the delalloc writepages to allocate
	blocks at the right offset.

On Wed, Nov 26, 2008 at 12:53:21AM -0500, Theodore Tso wrote:
> On Fri, Nov 07, 2008 at 03:12:27PM +0530, Aneesh Kumar K.V wrote:
> > When iterating through the pages with all mapped buffer_heads
> > we failed to update the b_state value. This result in allocating
> > blocks at logical offset 0.
> > 
> > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>
> 
> Hey Aneesh,
> 
> I've been going through patches in the patch queue and I noticed that
> the subsequent patch 
> 
> [PATCH 2/2] ext4: Mark the buffer_heads as dirty and uptodate after prepare_write
> 
> has been merged to mainline, but this one wasn't.  From looking at the
> e-mail record, you said that the second one fixed the rtorrent
> corruption --- but looking at this patch and its description, it looks
> like this one should perhaps get pushed to Linus ASAP as well.  Do you
> remember if both patches were needed to fix the rtorrent corruption
> problem, or only the second one?

Both patches are not needed to fix the rtorrent problem. The second
patch actually fix the rtorrent issue.

-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html