lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Dec 2008 20:15:35 +0530 From: "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com> To: Theodore Tso <tytso@....edu> Cc: Ric Wheeler <rwheeler@...hat.com>, Andreas Dilger <adilger@....com>, Josef Bacik <jbacik@...hat.com>, linux-ext4@...r.kernel.org Subject: Re: [PATCH] ext4: add fsync batch tuning knobs On Tue, Nov 25, 2008 at 05:22:32AM -0500, Theodore Tso wrote: .... ... > {Opt_bh, "bh"}, > {Opt_commit, "commit=%u"}, > + {Opt_min_batch_time, "min_batch_time=%u"}, > + {Opt_max_batch_time, "max_batch_time=%u"}, > {Opt_journal_update, "journal=update"}, > {Opt_journal_inum, "journal=%u"}, > {Opt_journal_dev, "journal_dev=%u"}, > @@ -1107,6 +1119,20 @@ static int parse_options(char *options, struct super_block *sb, > option = JBD2_DEFAULT_MAX_COMMIT_AGE; > sbi->s_commit_interval = HZ * option; > break; > + case Opt_max_batch_time: > + if (match_int(&args[0], &option)) > + return 0; > + if (option < 0) > + return 0; > + if (option == 0) > + option = EXT4_DEF_MAX_BATCH_TIME; > + sbi->s_max_batch_time = option; We need a break here . > + case Opt_min_batch_time: > + if (match_int(&args[0], &option)) > + return 0; > + if (option < 0) > + return 0; > + sbi->s_min_batch_time = option; same here > case Opt_data_journal: > data_opt = EXT4_MOUNT_JOURNAL_DATA; > goto datacheck; > @@ -1955,6 +1981,9 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) > > sbi->s_resuid = le16_to_cpu(es->s_def_resuid); > sbi->s_resgid = le16_to_cpu(es->s_def_resgid); > + sbi->s_commit_interval = JBD2_DEFAULT_MAX_COMMIT_AGE * HZ; > + sbi->s_min_batch_time = EXT4_DEF_MIN_BATCH_TIME; > + sbi->s_max_batch_time = EXT4_DEF_MAX_BATCH_TIME; > > set_opt(sbi->s_mount_opt, RESERVATION); > set_opt(sbi->s_mount_opt, BARRIER); .... .. The patch also needs documentation of new mount options -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists