linux-ext4 - Re: [patch 101/104] ext3: dont try to resize if there are no reserved gdt blocks left

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 04 Dec 2008 17:07:55 -0500
From:	Valdis.Kletnieks@...edu
To:	Greg KH <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>, Willy Tarreau <w@....eu>,
	Rodrigo Rubira Branco <rbranco@...checkpoint.com>,
	Jake Edge <jake@....net>, Eugene Teo <eteo@...hat.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Josef Bacik <jbacik@...hat.com>,
	linux-ext4@...r.kernel.org, Andreas Dilger <adilger@....com>
Subject: Re: [patch 101/104] ext3: dont try to resize if there are no reserved gdt blocks left

On Wed, 03 Dec 2008 11:56:53 PST, Greg KH said:

>  	if (reserved_gdb || gdb_off == 0) {
>  		if (!EXT3_HAS_COMPAT_FEATURE(sb,
> -					     EXT3_FEATURE_COMPAT_RESIZE_INODE))
{
> +					     EXT3_FEATURE_COMPAT_RESIZE_INODE)
> +		    || !le16_to_cpu(es->s_reserved_gdt_blocks)) {
>  			ext3_warning(sb, __func__,
>  				     "No reserved GDT blocks, can't resize");
>  			return -EPERM;

What's the codepath if the compat_feature part trips, but the le16_to_cpu
doesn't?  Looks to me like it will then skip over the 'return -EPERM'?

Content of type "application/pgp-signature" skipped