linux-ext4 - [PATCH] ext4: fix null pointer deref on mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4961603B.5020505@ph.tum.de>
Date:	Mon, 05 Jan 2009 02:19:55 +0100
From:	Thiemo Nagel <thiemo.nagel@...tum.de>
To:	Ext4 Developers List <linux-ext4@...r.kernel.org>
CC:	tytso@....edu
Subject: [PATCH] ext4: fix null pointer deref on mount

I came across a null pointer dereference when mounting an intentionally 
corrupted filesystem (cf. debug.dmesg).  In my opinion, the problem lies 
in ext4_fill_super(), where truncation may occur on setting the integer 
db_count, which results in too little memory being allocated for 
sbi->s_group_desc.  The attached patch (against 2.6.28) fixes this by 
changing the type of db_count to unsigned long.  I also took the 
opportunity to make the check against sign extension in calculation of 
db_count more strict, so that it now excludes cases in which db_count 
comes out as zero.

Comments are welcome!

Signed-off-by: Thiemo Nagel <thiemo.nagel@...tum.de>

View attachment "null_deref.patch" of type "text/x-diff" (927 bytes)

View attachment "debug.dmesg" of type "text/plain" (5485 bytes)