linux-ext4 - Re: [PATCH V5 3/5]ext4: quota handling for delayed allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090106093936.GF10705@duck.suse.cz>
Date:	Tue, 6 Jan 2009 10:39:36 +0100
From:	Jan Kara <jack@...e.cz>
To:	Mingming Cao <cmm@...ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz>,
	tytso <tytso@....edu>, linux-ext4 <linux-ext4@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH V5 3/5]ext4: quota handling for delayed allocation

On Tue 06-01-09 10:35:29, Jan Kara wrote:
> On Mon 05-01-09 20:40:55, Mingming Cao wrote:
> > ext4: quota reservation for delayed allocation
> > 
> > Uses quota reservation/claim/release to handle quota properly for delayed
> > allocation in the three steps: 1) quotas are reserved when data being copied
> > to cache when block allocation is defered 2) when new blocks are allocated.
> > reserved quotas are converted to the real allocated quota, 2) over-booked
> > quotas for metadata blocks are released back.
> > 
> > Signed-off-by: Mingming Cao <cmm@...ibm.com>
>   The patch looks fine as far as I can tell :). But I'm not to familiar
> with the code so I won't add my Acked-by...
  On a second thought:

> > +unsigned long long ext4_get_reserved_space(struct inode *inode)
> > +{
> > +	unsigned long long total;
> > +
> > +	spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
> > +	total = EXT4_I(inode)->i_reserved_data_blocks +
> > +		EXT4_I(inode)->i_reserved_meta_blocks;
> > +	spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
> > +
> > +	return total;
> > +}
  Shouldn't we return here (total << inode->i_blksize)? Quota expects
bytes as output...

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html