linux-ext4 - Re: [PATCH V5 1/5] quota: Add reservation support for delayed block allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231893775.8719.22.camel@mingming-laptop>
Date:	Tue, 13 Jan 2009 16:42:55 -0800
From:	Mingming Cao <cmm@...ibm.com>
To:	Jan Kara <jack@...e.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, tytso <tytso@....edu>,
	linux-ext4 <linux-ext4@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH V5 1/5] quota: Add reservation support for delayed
	block allocation


在 2009-01-13二的 20:09 +0100，Jan Kara写道：
> On Tue 13-01-09 10:53:17, Mingming Cao wrote:
> > 在 2009-01-13二的 16:37 +0100，Jan Kara写道：
> > > On Mon 12-01-09 16:19:06, Mingming Cao wrote:
> > > > Thanks for your review and suggestions. All points are taken. I have
> > > > updated the quota patches.I am attaching the updated patch here just for
> > > > your review.
> > > > 
> > > > I am waiting for the ext4 tree to updated to rebase the whole series
> > > > against 2.6.29-rc1 plus ext4 patch queue.  
> > > > 
> > >   <snip>
> > > > Quota: Add quota reservation support
> > > > 
> > > > Delayed allocation defers the block allocation at the dirty pages
> > > > flush-out time, doing quota charge/check at that time is too late.
> > > > But we can't charge the quota blocks until blocks are really allocated,
> > > > otherwise users could get overcharged after reboot from system crash.
> > > > 
> > > > This patch adds quota reservation for delayed llocation. Quota blocks
> > > > are reserved in memory, inode and quota won't gets dirtied until later
> > > > block allocation time.
> > > > 
> > > > Signed-off-by: Mingming Cao <cmm@...ibm.com>
> > >   The patch is fine. You can add
> > > 
> > >   Acked-by: Jan Kara <jack@...e.cz>
> > > 
> > >   How do you want to merge the patches? Via ext4 patch queue?
> > > There's one generic quota patch that I also need to push to fix some OCFS2
> > > issue and it collides with your patchset. And also there're further
> > > cleanups in quota code which are long overdue which I want to base on all
> > > other patches. So I've decided to setup quota git tree. I'll pull in your
> > > two VFS quota patches. Will that work for you?
> > 
> > I think a quota tree is the best place to hold all these quota changes.
> > The ext4 part probably make sense to stay together with the vfs changes,
> > but it will need to coordinate with Ted's ext4 tree.  Ted, what do you
> > think?
>   Yes. The best would be if could pull quota changes from my tree but you
> could also just carry your two patches and only leave merging them with
> vanilla to me.
> 
Sure, that works for me.

> > BTW, there are other two quota cleanup patches that you have already
> > acked. I will sent the 2.6.29-rc1 based version.
>   Yes. Thanks.
> 

Attached are all the 5 2.6.29-rc1 based patches, including the two
cleanups.

Thanks!

Mingming

View attachment "quota-make-reservation-vfs.patch" of type "text/x-patch" (9611 bytes)

View attachment "quota-claim-reservation-vfs.patch" of type "text/x-patch" (8523 bytes)

View attachment "ext4-delalloc-quota-spt.patch" of type "text/x-patch" (7494 bytes)

View attachment "quota-inode-blkbits-cleanup.patch" of type "text/x-patch" (2591 bytes)

View attachment "quota-exported-symbols-cleanup.patch" of type "text/x-patch" (9029 bytes)