linux-ext4 - Re: [PATCH] ext3: wait on all pending commits in ext3_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090114042402.GH14730@mit.edu>
Date:	Tue, 13 Jan 2009 23:24:02 -0500
From:	Theodore Tso <tytso@....edu>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	Jan Kara <jack@...e.cz>, Arthur Jones <ajones@...erbed.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
	"sct@...hat.com" <sct@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ext3: wait on all pending commits in ext3_sync_fs

On Tue, Jan 13, 2009 at 04:14:11PM -0600, Eric Sandeen wrote:
> 
> This looks sane to me, and it does fix the below testcase.
> 
> Care to formally propose it?

Can we confirm what is being proposed?  From following this thread, I
think what folks are suggesting is:

1)  Revert the current "ext3/4: wait on all pending ocmmits in ext3/4_sync_fs"

2)  Apply Jan's patch "jbd[2]: Fix return value of journal_start_commit()"

3)  Also apply Jan's patch "jbd2: Skip commit of a transaction without
any buffers" since it appears to be a good optimization (although it's
not clear it would happen once we revert (1), above.

    	     	   	       	  	      - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html