linux-ext4 - Re: ext4 fails on ext2 filesystems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090121184221.GA2063@alea.gnuu.de>
Date:	Wed, 21 Jan 2009 19:45:17 +0100
From:	Jörg Sommer <joerg@...a.gnuu.de>
To:	Theodore Tso <tytso@....edu>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: ext4 fails on ext2 filesystems

Hi Theodore,

Theodore Tso schrieb am Tue 20. Jan, 09:51 (-0500):
> On Sun, Jan 18, 2009 at 11:04:59AM +0100, Jörg Sommer wrote:
> > > > [  203.082300] EXT4 FS on hda3, no journal
> > > > [  205.746713] EXT4-fs error (device hda3): ext4_free_data: circular indirect block detected, inode=165056, block=184476
> > > > 
> 
> Hi, this patch should fix your problem.

Yes, this patch fixes the problem. Thanks.

> commit bf3baec2b4529dcf47ee422a48b8c0e83df7f0a0
> Author: Theodore Ts'o <tytso@....edu>
> Date:   Tue Jan 20 09:50:19 2009 -0500
> 
>     ext4: Fix ext4_free_blocks() w/o a journal when files have indirect blocks
>     
>     When trying to unlink a file with indirect blocks on a filesystem
>     without a journal, the "circular indirect block" sanity test was
>     getting falsely triggered.
>     
>     Signed-off-by: "Theodore Ts'o" <tytso@....edu>

Tested-by: Jörg Sommer <joerg@...a.gnuu.de>

> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 49484ba..b4386da 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3622,7 +3622,7 @@ static void ext4_free_data(handle_t *handle, struct inode *inode,
>  		 * block pointed to itself, it would have been detached when
>  		 * the block was cleared. Check for this instead of OOPSing.
>  		 */
> -		if (bh2jh(this_bh))
> +		if ((EXT4_JOURNAL(inode) == NULL) || bh2jh(this_bh))
>  			ext4_handle_dirty_metadata(handle, inode, this_bh);
>  		else
>  			ext4_error(inode->i_sb, __func__,
> 

Bye, Jörg.
-- 
Freiheit heißt, die Wahl zu haben, wessen Sklave man ist.

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)