linux-ext4 - [PATCH] ext2: Mark the buffer as unmapped before reading the next quota block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 2 Feb 2009 15:34:27 +0530
From:	Manish Katiyar <mkatiyar@...il.com>
To:	"Theodore Ts'o" <tytso@....edu>, ext4 <linux-ext4@...r.kernel.org>,
	Jan Kara <jack@...e.cz>, cmm@...ibm.com
Cc:	mkatiyar@...il.com
Subject: [PATCH] ext2: Mark the buffer as unmapped before reading the next 
	quota block

Hi Jan,

This is in continuation with the previous patch
(http://patchwork.ozlabs.org/patch/20275/) . We also need to set the
buffer as unmapped before reading the next block. I don't think quota
files can have holes, but atleast for correctness, otherwise once we
have read a block, tmp_bh is always mapped even for holes.


Signed-off-by: Manish Katiyar <mkatiyar@...il.com>
---
 fs/ext2/super.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index da8bdea..b4e7633 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1328,6 +1328,7 @@ static ssize_t ext2_quota_read(struct
super_block *sb, int type, char *data,
 				sb->s_blocksize - offset : toread;

 		tmp_bh.b_state = 0;
+		clear_buffer_mapped(&tmp_bh);
 		err = ext2_get_block(inode, blk, &tmp_bh, 0);
 		if (err < 0)
 			return err;
-- 
1.5.4.3


Thanks -
Manish
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html