linux-ext4 - typo in jbd2_journal_begin_ordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0902012309120.26166@bikeee>
Date:	Tue, 3 Feb 2009 11:23:03 +0300 (EAT)
From:	Dan Carpenter <error27@...il.com>
To:	sct@...hat.com, akpm@...ux-foundation.org
cc:	linux-ext4@...r.kernel.org
Subject: typo in jbd2_journal_begin_ordered_truncate()

This is jbd2_journal_begin_ordered_truncate() from fs/jbd2/transaction.c.

I think the "&&" is supposed to be an "||" on line 2144.  Just knowing 
that inode->i_transaction is NULL should be enough, otherwise we would 
immediately dereference a null on line 2146.

   2144          if (!inode->i_transaction && !inode->i_next_transaction)
   2145                  goto out;
   2146          journal = inode->i_transaction->t_journal;

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html